This is just a squash and minor cleanup of #396. LG fixed a few bugs and rearranged the parameter ordering of those fread/fwrite helper functions (to match the built-in one, less confusing that way). It changed enough that I thought it worth showing everybody before a commit. I couldn't amend Kevin's pull request, so I just submitted another, but this is really just a revision of that request.
Here's the final log entry: Fix many compiler warnings and beef up I/O error checking: * Many cases where we were ignoring the results of fread or fwrite, so now we religiously check the results and set errors appropriately (this affected bmp, fits, ico, jpeg2000, sgi, targa, tiff, webp, zfile). * Some unused variables. This work was mostly Kevin Brightwell, with a cleanup pass by Larry Gritz. You can merge this Pull Request by running: git pull https://github.com/OpenImageIO/oiio kevin-lg-squash Or you can view, comment on it, or merge it online at: https://github.com/OpenImageIO/oiio/pull/413 -- Commit Summary -- * Fix many compiler warnings and beef up I/O error checking: -- File Changes -- M .gitignore (3) M src/bmp.imageio/bmp_pvt.cpp (151) M src/bmp.imageio/bmpoutput.cpp (4) M src/dpx.imageio/libdpx/DPXHeader.h (52) M src/fits.imageio/fitsoutput.cpp (12) M src/hdr.imageio/rgbe.cpp (7) M src/ico.imageio/icooutput.cpp (76) M src/iinfo/iinfo.cpp (2) M src/jpeg2000.imageio/jpeg2000output.cpp (6) M src/libtexture/imagecache.cpp (2) M src/libtexture/texturesys.cpp (19) M src/libutil/sysutil.cpp (4) M src/oiiotool/printinfo.cpp (2) M src/ptex.imageio/ptex/PtexWriter.cpp (9) M src/sgi.imageio/sgi_pvt.h (11) M src/sgi.imageio/sgioutput.cpp (42) M src/targa.imageio/targaoutput.cpp (210) M src/tiff.imageio/tiffinput.cpp (4) M src/webp.imageio/webpinput.cpp (8) M src/webp.imageio/webpoutput.cpp (6) M src/zfile.imageio/zfile.cpp (19) -- Patch Links -- https://github.com/OpenImageIO/oiio/pull/413.patch https://github.com/OpenImageIO/oiio/pull/413.diff --- Reply to this email directly or view it on GitHub: https://github.com/OpenImageIO/oiio/pull/413 _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
