There are 4 public functions, to allow the user maximum control over how he applies contrast. He can specify one pivot and one contrast value for all channels, one pivot for all channels and contrast values per channel, etc.
Each of these 4 functions only prepare the arguments, nothing else, and then they call another function that does input validation and that function then calls contrast_impl. It only makes sense to apply contrast to the luminance channel if only one pivot and one contrast value is specified, that is why one of the public functions has an additional parameter luminance. You can merge this Pull Request by running: git pull https://github.com/StefanStavrev/oiio contrast Or you can view, comment on it, or merge it online at: https://github.com/OpenImageIO/oiio/pull/419 -- Commit Summary -- * Minor fixes for over * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Merge remote-tracking branch 'upstream/master' * Contrast -- File Changes -- M src/include/imagebufalgo.h (64) M src/libOpenImageIO/imagebufalgo.cpp (193) M src/oiiotool/oiiotool.cpp (150) -- Patch Links -- https://github.com/OpenImageIO/oiio/pull/419.patch https://github.com/OpenImageIO/oiio/pull/419.diff --- Reply to this email directly or view it on GitHub: https://github.com/OpenImageIO/oiio/pull/419 _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
