I don't know what you mean. The patch I merged definitely had code changes as
well as tests. It should all be in the current master.
-- lg
On Jan 27, 2015, at 9:43 AM, ran sariel <[email protected]> wrote:
> Hi
>
> I downloaded and rebuilt master. seems that the changes are not in the main
> /src folder but in testsuite.
> not sure if I'm building oiio correctly (the build instructions do not
> mention testsuite at all)
> Am I missing the correct branch? or should I apply the changes locally from
> the testsuite files to the /src folder
>
>
> Cheers
> Ran
>
>
> On 01/26/2015 11:20 AM, Larry Gritz wrote:
>> FYI, I have merged this fix into master.
>>
>> Since we're trying to push out a stable 1.5 release (today, ideally!), I
>> didn't want to mess with that branch. Let's test this change in master for a
>> while, and then if there is demand for a back-port, we can consider making
>> the change in 1.5 as well.
>>
>> -- lg
>>
>>
>> On Jan 23, 2015, at 5:53 PM, ran sariel<[email protected]> wrote:
>>
>>> Thank you Larry, that's great news.
>>> ( I actually tried to set the --attrib for pixelAspectRatio, but it wasn't
>>> recognized by RV so I was assuming I got it wrong..)
>>>
>>> Cheers
>>> Ran
>>>
>>> On 01/23/2015 04:08 PM, Larry Gritz wrote:
>>>> OK, I did some digging, and it's a bit of a good news / bad news situation.
>>>>
>>>> Bad news: JPEG doesn't directly store the pixel aspect ratio in its
>>>> metadata.
>>>>
>>>> Good news: JPEG does store "density" (dots per inch or cm in x and y), and
>>>> so the pixel aspect ratio is implied to be ydensity/xdensity.
>>>>
>>>> Bad news: our JPEG reader (and writer) didn't handle xdensity and ydensity
>>>> properly. (This is supposed to correspond to the standard OIIO metadata
>>>> called "XResolution" and "YResolution", which are confusing names, but
>>>> they are simply inherited from TIFF nomenclature.)
>>>>
>>>> Good news: I have a pull request
>>>> (https://github.com/OpenImageIO/oiio/pull/1042) that fixes it, and also
>>>> tightens up the way we handle the mutual interactions of XResolution,
>>>> YResolution, and PixelAspectRatio.
>>>>
>>>> Once this PR is approved and merged, you'll be able to set the implied
>>>> pixel aspect ratio of a JPEG file like this:
>>>>
>>>> oiiotool input.jpg -attrib "PixelAspectRatio" 1.1 -o nonsquare.jpg
>>>>
>>>>
>>>> On Jan 22, 2015, at 9:46 AM, ran sariel<[email protected]> wrote:
>>>>
>>>>> just change the metadata
>>>>>
>>>>> On 01/22/2015 12:30 AM, Larry Gritz wrote:
>>>>>> aspect ratio
>>>>> --
>>>>> Ran Sariel
>>>>> CTO / Pipeline supervisor
>>>>> The Embassy VFX Inc.
>>>>> 177 West 7th Ave, 4th Floor
>>>>> Vancouver, BC
>>>>> Phone: (604) 696-6862 ext. 244
>>>>>
>>>>> [email protected]
>>>>>
>>>> --
>>>> Larry Gritz
>>>> [email protected]
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Oiio-dev mailing list
>>>> [email protected]
>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>> --
>>> Ran Sariel
>>> CTO / Pipeline supervisor
>>> The Embassy VFX Inc.
>>> 177 West 7th Ave, 4th Floor
>>> Vancouver, BC
>>> Phone: (604) 696-6862 ext. 244
>>>
>>> [email protected]
>>>
>>> _______________________________________________
>>> Oiio-dev mailing list
>>> [email protected]
>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>> --
>> Larry Gritz
>> [email protected]
>>
>>
>>
>> _______________________________________________
>> Oiio-dev mailing list
>> [email protected]
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>
> --
> Ran Sariel
> CTO / Pipeline supervisor
> The Embassy VFX Inc.
> 177 West 7th Ave, 4th Floor
> Vancouver, BC
> Phone: (604) 696-6862 ext. 244
>
> [email protected]
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
