Wait, but looking at it further, I don't that's the "correct" fix.

Forget what I said before, and let's try something else.

In the calling function, handle_sequence(), at oiiotool.cpp (line 3766 for you, 
line 4319 in the current master),


            Filesystem::enumerate_file_sequence (normalized_pattern,
                                                 frame_numbers[a],
                                                 views,
                                                 filenames[a]);


I think 'views' (third parameter) should actually be 'frame_views[a]'. I think 
that's the real mistake.

Can you give that a shot?



On Feb 12, 2015, at 3:31 PM, Christoph Gohlke <[email protected]> wrote:

> Thank you. That seems to fix the crash. I updated my binaries for Simon to 
> confirm.
> 
> Christoph
> 
> 
> On 2/12/2015 2:47 PM, Larry Gritz wrote:
>> No, but I have an idea for you to try, based on the lines where you said
>> the crash happens.
>> 
>> In filesystem.cpp, line 665 (in your version), try changing
>> 
>>     views.size() > 0
>> 
>> to
>> 
>>     views.size() > i
>> 
>> and see if that helps.
>> 
>> 
>> On Feb 12, 2015, at 2:31 PM, Simon Björk <[email protected]
>> <mailto:[email protected]>> wrote:
>> 
>>> Thanks for taking a look Larry. Yes I get a complete crash of
>>> oiiotool, no error message. I'm on Windows 7. Files are readable
>>> (tried with different sequences).
>>> 
>>> One thing I noticed though is that I sometimes could get a render
>>> going with two frames, but not more. Need to test this more to be sure
>>> though. Does this make any sense?
>>> 
>>> Skickat från min iPhone
>>> 
>>> 12 feb 2015 kl. 22:30 skrev Larry Gritz <[email protected]
>>> <mailto:[email protected]>>:
>>> 
>>>> I tried on my end with master, the current head of 1.5, as well as
>>>> 1.4.16, and with all three it worked fine for me (on OSX, though I'm
>>>> fairly confident about Linux as well because we use this every day at
>>>> my work).
>>>> 
>>>> Does it really "crash", or do you get an error message?
>>>> 
>>>> Do the files img.1001.jpg through img.1005.jpg exist and are readable
>>>> individually?
>>>> 
>>>> What platform are  you running on?
>>>> 
>>>> 
>>>> On Feb 12, 2015, at 5:50 AM, Simon Björk <[email protected]
>>>> <mailto:[email protected]>> wrote:
>>>> 
>>>>> Hi all,
>>>>> 
>>>>> I've been using a precompiled
>>>>> <http://www.lfd.uci.edu/%7Egohlke/pythonlibs/> version of
>>>>> OpenImageIO (by Christoph Gohlke), and so far it's been working
>>>>> great (using 1.3). However I recently upgraded to 1.4.16 and now I
>>>>> get crashes using the --frames argument with oiiotool.
>>>>> 
>>>>> For example, if I run: oiiotool img.%04d.jpg --frames 1001-1005
>>>>> -o new_img.%04d.jpg I get a crash. This used to work in 1.3.
>>>>> 
>>>>> According to Christoph, the crashes occur here:
>>>>> https://github.com/OpenImageIO/oiio/blob/RB-1.4/src/oiiotool/oiiotool.cpp#L3766
>>>>> https://github.com/OpenImageIO/oiio/blob/RB-1.4/src/libutil/filesystem.cpp#L665
>>>>> 
>>>>> Is this working for others?
>>>>> 
>>>>> Best regards,
>>>>> Simon
>>>>> 
>>>>> 
>>>>> -------------------------------
>>>>> Simon Björk
>>>>> Compositor/TD
>>>>> 
>>>>> +46 (0)70-2859503
>>>>> www.bjorkvisuals.com <http://www.bjorkvisuals.com/>
>>>>> 
>>>> 
>>>> --
>>>> Larry Gritz
>>>> [email protected] <mailto:[email protected]>
>>>> 
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Oiio-dev mailing list
>>>> [email protected] <mailto:[email protected]>
>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>> _______________________________________________
>>> Oiio-dev mailing list
>>> [email protected] <mailto:[email protected]>
>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>> 
>> --
>> Larry Gritz
>> [email protected] <mailto:[email protected]>
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Oiio-dev mailing list
>> [email protected]
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>> 
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

--
Larry Gritz
[email protected]



_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

Reply via email to