In case you didn't see the results of my tinkering so far:
https://github.com/OpenImageIO/oiio/pull/1207
<https://github.com/OpenImageIO/oiio/pull/1207>
This patch lets you read JPEG-compressed TIFF files. Well, most of them. The
ones in the libtiff testsuite seem to work fine, but the Lena picture you
attached a couple days ago is the one image I can't make it read, it crashes
inside libtiff. (I don't have the writing completely working yet, it's hard to
work on and test writing if you aren't confident that you're reading properly.)
Is the Lena image by any chance the "corrupted JPEG-in-TIFF" you talk about? If
the only image that doesn't read with my patch is known to be corrupted, I'm
ready to declare that working and just concentrating on making sure we can
write JPEG-in-TIFF.
I don't think it's a threading issue. A simple "iconvert" or "iv" involving a
JPEG-compressed TIFF should not spawn multiple threads. (Most ImageBufAlgo
image processing functions use threads to speed up, but those don't come into
play for a simple image copy or format conversion.)
-- lg
> On Aug 27, 2015, at 12:39 PM, Yang Yang <[email protected]> wrote:
>
> I found out the difference between corrupted file and good file in metadata
> is StripOffsets.
> Maybe this can shed some lights on this issue.
>
> Corrupted JPEG-in-TIFF:
>
> ImageWidth (1 Short): 512
> ImageLength (1 Short): 512
> BitsPerSample (3 Short): 8, 8, 8
> Compression (1 Short): JPEG Technote #2
> Photometric (1 Short): RGB
> StripOffsets (16 Long): 1281, 5665, 10846, 16765, 23175, 29579,...
> Orientation (1 Short): TopLeft
> SamplesPerPixel (1 Short): 3
> RowsPerStrip (1 Short): 32
> StripByteCounts (16 Long): 4384, 5181, 5919, 6410, 6404, 7070, 6982,...
> PlanarConfig (1 Short): Contig
> XPosition (1 Rational): 0
> YPosition (1 Rational): 0
> DateTime (20 ASCII): 2015:08:27 14:31:22
> SampleFormat (3 Short): 1, 1, 1
> JpegTables (289 Undefined):
> 700 (899 Byte): 60, 63, 120, 112, 97, 99, 107, 101, 116, 32,...
> 34665 (1 IFD): 172230
>
> GOOD JPEG-in-TIFF:
>
> ImageWidth (1 Short): 512
> ImageLength (1 Short): 512
> BitsPerSample (3 Short): 8, 8, 8
> Compression (1 Short): JPEG Technote #2
> Photometric (1 Short): RGB
> StripOffsets (16 Long): 1583, 5967, 11148, 17067, 23477, 29881,...
> Orientation (1 Short): TopLeft
> SamplesPerPixel (1 Short): 3
> RowsPerStrip (1 Short): 32
> StripByteCounts (16 Long): 4384, 5181, 5919, 6410, 6404, 7070, 6982,...
> PlanarConfig (1 Short): Contig
> XPosition (1 Rational): 0
> YPosition (1 Rational): 0
> DateTime (20 ASCII): 2015:08:27 11:28:45
> SampleFormat (3 Short): 1, 1, 1
> JpegTables (289 Undefined):
> 700 (899 Byte): 60, 63, 120, 112, 97, 99, 107, 101, 116, 32,...
> 34665 (1 IFD): 173740
>
> 2015-08-26 15:29 GMT-05:00 Yang Yang <[email protected]
> <mailto:[email protected]>>:
> I tried, but no luck :(
>
>
>
> 2015-08-26 11:22 GMT-05:00 Thiago Ize <[email protected]
> <mailto:[email protected]>>:
> Shot in the dark: If it's a race condition that's causing it to crash, would:
> OIIO::attribute ("threads", 1);
> perhaps help?
>
> On Wed, Aug 26, 2015 at 10:17 AM, Yang Yang <[email protected]
> <mailto:[email protected]>> wrote:
> Hi Larray,
>
> I attached a file that generated during debug process. The file can be load
> correctly in IrfanView.
> OpenImageIO indeed calls jpeg encoder to generate it. But I cannot generate
> it without setting break point in Visual studio.
>
> I found the following link information about Jpeg in TIFF:
> http://www.remotesensing.org/libtiff/TIFFTechNote2.html
> <http://www.remotesensing.org/libtiff/TIFFTechNote2.html>
>
> This link give a use case for JPEG in TIFF:
> http://iipimage.sourceforge.net/documentation/images/
> <http://iipimage.sourceforge.net/documentation/images/>
>
> Regards,
>
> Yang
>
> 2015-08-26 1:04 GMT-05:00 Larry Gritz <[email protected]
> <mailto:[email protected]>>:
> Ha, this has proven to be much more complicated than I thought!
>
> By any chance, do you have a JPEG-in-TIFF file that you are confident is
> correct (can be correctly read by some application you trust) that you can
> send me to use as a test case?
>
>
>
> > On Aug 25, 2015, at 11:36 AM, Larry Gritz <[email protected]
> > <mailto:[email protected]>> wrote:
> >
> > Yeah, the TIFF output doesn't have a "compression" value it recognizes that
> > will turn on JPEG compression. (I think this is the first time anybody has
> > requested it, I didn't know anybody cared about lossy compression with TIFF
> > files.)
> >
> > Should be really simple, I'll propose a patch shortly.
> >
> >
> >> On Aug 25, 2015, at 7:37 AM, Yang Yang <[email protected]
> >> <mailto:[email protected]>> wrote:
> >>
> >> Hi All,
> >>
> >> When I try to use JPEG as compression option for TIFF, I found out there
> >> is no JPEG support.
> >> However, when I try to add "JPEG_COMPRESS" option in to OpenImageIO, I
> >> found the output file is always corrupted. I already build libtiff with
> >> "new jpeg" enabled.
> >>
> >> I wonder that does anyone encounter this problem or not? How should I
> >> solve this issue.
> >>
> >>
> >> Thank in advance for your attention.
> >>
> >> Yang
> >
> >
>
> --
> Larry Gritz
> [email protected] <mailto:[email protected]>
>
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected] <mailto:[email protected]>
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected] <mailto:[email protected]>
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>
>
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected] <mailto:[email protected]>
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>
>
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
