Agreed, I like the warning in principle. I just don't want to have to go patrolling for tab/space issues in a file that's imported from another project, for a version of gcc that's not an official release and that I don't have on my machine. It's just to painful to do "remotely", and a waste of Richard's time.
When some version of gcc or clang that I use incorporates the warning (so I can have a tight compile/fix/compile loop all by my lonesome), I intend to fix the whitespace issues and then remove suppression of the warning. > On Feb 4, 2016, at 11:14 AM, Thiago Ize <[email protected]> wrote: > > By the way, I do think this is a great warning if it worked. Suppose you > have: > > if (foo) > bar(); > bat(); > baz(); > > I would appreciate being warned about this. If they fix this so that there > are very few false positives (or is this already the only false positive?), > it would be nice to reenable that warning and instead fix the couple of > remaining false positives. > > On Thu, Feb 4, 2016 at 12:09 PM, Thiago Ize <[email protected] > <mailto:[email protected]>> wrote: > I'd recommend reporting that to the gcc devs as well since that's buggy code. > In this case the tab and white space indentation match when I look at it in > my editor, so there should be no error. But it seems like gcc is using a > different number of spaces per tab, so it's not matching for them. They > should do something more intelligent or disable this when there is a mix of > spaces and tabs. > > On Thu, Feb 4, 2016 at 12:08 PM, Larry Gritz <[email protected] > <mailto:[email protected]>> wrote: > Perhaps the official build server has a *slightly* updated gcc6, in which > they added this new warning? > > I understand the intent of warning when the indentation doesn't appear to > match the syntax. But this is a case of a file we imported from another > project, and it's got a mix of spaces and tabs that is triggering the error. > Looks totally clear and fine in an editor, frankly I think it's a "false > positive." Easiest thing is to just suppress that error. > > >> On Feb 4, 2016, at 11:03 AM, Richard Shaw <[email protected] >> <mailto:[email protected]>> wrote: >> >> On Thu, Feb 4, 2016 at 1:00 PM, Larry Gritz <[email protected] >> <mailto:[email protected]>> wrote: >> It's complaining about indentation! >> >> Sheesh. >> >> Must be a GCC 6 new warning. Nothing has changed here and it's never been a >> warning before. >> >> Hang on, I'll prepare a PR that suppresses the error. >> >> What's weird is I don't get those errors when I build in a Rawhide chroot >> (via mock), only when I build on the official servers, but they should be >> running the same packages. >> >> Thanks, >> Richard >> > > -- > Larry Gritz > [email protected] <mailto:[email protected]> > > > > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org -- Larry Gritz [email protected]
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
