I think these have now been fixed by PR #1843, which I have merged into both master and RB-1.8.
> On Dec 19, 2017, at 6:51 AM, Richard Shaw <[email protected]> wrote: > > I got the following error trying to build 1.8.6 with the pull request to fix > GL for ES systems... > > /builddir/build/BUILD/oiio-Release-1.8.6/src/dicom.imageio/dicominput.cpp: In > member function 'void OpenImageIO_v1_8::DICOMInput::read_metadata()': > /builddir/build/BUILD/oiio-Release-1.8.6/src/dicom.imageio/dicominput.cpp:301:56: > error: cannot bind non-const lvalue reference of type 'Sint32& {aka long > int&}' to an rvalue of type 'Sint32 {aka long int}' > if (dataset->findAndGetSint32 (tag, val).good()) > ^ > In file included from /usr/include/dcmtk/dcmdata/dctk.h:50:0, > from > /builddir/build/BUILD/oiio-Release-1.8.6/src/dicom.imageio/dicominput.cpp:40: > /usr/include/dcmtk/dcmdata/dcitem.h:759:17: note: initializing argument 2 > of 'OFCondition DcmItem::findAndGetSint32(const DcmTagKey&, Sint32&, long > unsigned int, bool)' > OFCondition findAndGetSint32(const DcmTagKey &tagKey, > ^~~~~~~~~~~~~~~~ > /builddir/build/BUILD/oiio-Release-1.8.6/src/dicom.imageio/dicominput.cpp:305:56: > error: cannot bind non-const lvalue reference of type 'Uint32& {aka long > unsigned int&}' to an rvalue of type 'Uint32 {aka long unsigned int}' > if (dataset->findAndGetUint32 (tag, val).good()) > ^ > In file included from /usr/include/dcmtk/dcmdata/dctk.h:50:0, > from > /builddir/build/BUILD/oiio-Release-1.8.6/src/dicom.imageio/dicominput.cpp:40: > /usr/include/dcmtk/dcmdata/dcitem.h:731:17: note: initializing argument 2 > of 'OFCondition DcmItem::findAndGetUint32(const DcmTagKey&, Uint32&, long > unsigned int, bool)' > OFCondition findAndGetUint32(const DcmTagKey &tagKey, > ^~~~~~~~~~~~~~~~ > > I already have a patch to deal with the version of dcmtk... > > --- a/src/dicom.imageio/dicominput.cpp > +++ b/src/dicom.imageio/dicominput.cpp > @@ -288,7 +288,7 @@ DICOMInput::read_metadata () > if (dataset->findAndGetFloat32 (tag, val).good()) > m_spec.attribute (name, val); > } else if (evr == EVR_FD > -#if PACKAGE_VERSION_NUMBER >= 361 > +#if PACKAGE_VERSION_NUMBER >= 362 > || evr == EVR_OD > #endif > ) { > @@ -312,7 +312,7 @@ DICOMInput::read_metadata () > evr == EVR_DT || evr == EVR_LT || evr == EVR_PN || > evr == EVR_ST || evr == EVR_TM || evr == EVR_UI || > evr == EVR_UT || evr == EVR_LO || evr == EVR_SH > -#if PACKAGE_VERSION_NUMBER >= 361 > +#if PACKAGE_VERSION_NUMBER >= 362 > || evr == EVR_UC ||evr == EVR_UR > #endif > ) { > > Thanks, > Richard > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org -- Larry Gritz [email protected]
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
