Nice.
Line 503 of intern/cycles/blender/blender_python.cpp must have been a bug, no?
There was never an implicit cast from ustring to std::string, so it must have
been incorrectly using the int cast and doing something very strange!
Thanks again, Thiago and John. You were right in suspecting that int conversion
was trouble. Sorry I took so long to understand.
-- lg
> On Dec 11, 2018, at 10:12 AM, Brecht Van Lommel <[email protected]>
> wrote:
>
> Blender itself was updated now:
> https://developer.blender.org/rB66d8bfb85c61aafe3bad2edf0e7b4d9d694ee2e7
> <https://developer.blender.org/rB66d8bfb85c61aafe3bad2edf0e7b4d9d694ee2e7>
> On Tue, Dec 11, 2018 at 6:49 AM Larry Gritz <[email protected]
> <mailto:[email protected]>> wrote:
> If line 456 is this one:
>
> ImageOutput *out = ImageOutput::create(filename);
>
> You want to change that to
>
> auto out = ImageOutput::create(filename);
>
> For 2.0, you could also have said
>
> std::unique_ptr<ImageOutput> out = ImageOutput::create(filename);
>
> But the beauty of C++11 'auto' is that not only is it shorter, but also it
> will work with both OIIO 1.8 (returning a raw pointer) or 2.0 (returning a
> unique_ptr).
>
>
>> On Dec 10, 2018, at 6:56 PM, Richard Shaw <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>> On Mon, Dec 10, 2018 at 4:05 PM Larry Gritz <[email protected]
>> <mailto:[email protected]>> wrote:
>> I'm not done writing this document yet, but I have already finished the
>> section that will give you the answer:
>>
>> https://github.com/OpenImageIO/oiio/wiki/OIIO-2.0-Porting-Guide
>> <https://github.com/OpenImageIO/oiio/wiki/OIIO-2.0-Porting-Guide>
>>
>> Ok, based on that I did the following but I'm still seeing the error at line
>> 456...
>>
>> --- a/intern/cycles/render/buffers.cpp
>> +++ b/intern/cycles/render/buffers.cpp
>> @@ -468,7 +468,10 @@ void DisplayBuffer::write(Device *device
>>
>> out->close();
>>
>> - delete out;
>> +#if OIIO_VERSION < 10903
>> + delete out;
>> +#endif
>> +
>> }
>>
>> Thanks,
>> Richard
>> _______________________________________________
>> Oiio-dev mailing list
>> [email protected] <mailto:[email protected]>
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>
> --
> Larry Gritz
> [email protected] <mailto:[email protected]>
>
>
>
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected] <mailto:[email protected]>
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
