It certainly looks simple and harmless. I'll apply it on my end and see if
anything breaks.
-- lg
> On Jan 31, 2019, at 11:47 AM, Alan Jones <[email protected]> wrote:
>
> Hi Johannes,
>
> Yes, it would need an opencolorio port first, then it should be
> straightforward to add it to openimageio.
>
> Larry, I've attached the changes that I'd made to get CMake Config Packages
> supported, which allowed find_package to work properly with the OIIO port in
> vcpkg. Do these changes have unintended consequences elsewhere? Also, I'm
> happy to try turning on python to use the vcpkg supplied python3 and see how
> that goes if that would meet use cases you had in mind.
>
> Cheers,
>
> Alan.
>
> On Wed, Jan 30, 2019 at 6:09 PM Johannes Hezer <[email protected]
> <mailto:[email protected]>> wrote:
> One other thing would be superb, is ocio support under windows, building oiio
> with ocio on windows seems sth not so trivial, also the ffmpeg support is
> greyed out in the appveyor.yml dont know if thatcould be changed too.
>
> There is not ocio package
> https://github.com/Microsoft/vcpkg/tree/master/ports
> <https://github.com/Microsoft/vcpkg/tree/master/ports> maybe that should be
> there first?
>
> Am 30/01/19 um 23:29 PM schrieb Alan Jones:
>> Hi Larry,
>>
>> So I've just learnt the pkg-config is not the thing I was after. There are
>> CMake config files it can output, which are detailed here
>> (https://cmake.org/cmake/help/v3.0/manual/cmake-packages.7.html#config-file-packages
>>
>> <https://cmake.org/cmake/help/v3.0/manual/cmake-packages.7.html#config-file-packages>)
>> that are a bit more robust than the Find*.cmake scripts. So that pull
>> request doesn't help with this particular issue.
>>
>> As far as python support goes, I've talked with the vcpkg folk and he's my
>> mangling of what they said that's hopefully still somewhat close to accurate.
>>
>> Vcpkg has python as a library, which they can build that can then be
>> embedded in an application. That's one that could be supported in the
>> OpenImageIO port file, but it may not be interoperable with the system
>> python depending upon toolchains etc. Would this meet your needs?
>>
>> Cheers,
>>
>> Alan.
>>
>> On Tue, Jan 29, 2019 at 5:39 PM Alan Jones <[email protected]
>> <mailto:[email protected]>> wrote:
>> Hi Larry,
>>
>> I'll give it a swing and try that. For the build all option, I'll try figure
>> it out and chat with the vcpkg team if I get stuck. I know there's the
>> ability to set options, but I'm not sure what beyond build flags it can do.
>>
>> Will let you know what I find.
>>
>> Cheers,
>>
>> Alan
>>
>>
>> On Tue, Jan 29, 2019, 5:21 PM Larry Gritz <[email protected]
>> <mailto:[email protected]>> wrote:
>> Actually, we have this active PR:
>> https://github.com/OpenImageIO/oiio/pull/2158
>> <https://github.com/OpenImageIO/oiio/pull/2158>
>>
>> Can you give that a try and see if it fits the bill? That would be
>> additional evidence in favor of merging it right away.
>>
>> Also, since I have you... Do you think it would be possible to augment the
>> vckpg setup to (either by default or with some kind of "build all" option)
>> build the Python bindings and the binary utilities such as oiiotool? These
>> are used in turn by other packages using OIIO (such as OSL) and it would
>> really solve a lot of problems for us if we could piggy-back on vcpkg for
>> people to easliy build OIIO and its dependencies.
>>
>>
>>> On Jan 29, 2019, at 4:46 PM, Alan Jones <[email protected]
>>> <mailto:[email protected]>> wrote:
>>>
>>
>>> Hi all,
>>>
>>> So I went to upgrade the OIIO version in vcpkg (which makes windows support
>>> quite trivial), and in doing so found that find_package didn't work by
>>> default because OIIO only provides Find-module CMake packages. I put
>>> together some changes that got Config-file packages supported by OIIO,
>>> though I'm not certain it was the correct way as I'm no CMake expert.
>>>
>>> The vcpkg team are happy to take an update, but for this one they wanted me
>>> to find out about OIIO interest in supporting Config-file packages (which
>>> are apparently generally superior/more CMakey than Find-packages). As if
>>> there isn't interest they'd like me to rename it to unofficial.
>>>
>>> I also provided them feedback that their package name was as odds with the
>>> project as they had openimageio instead of OpenImageIO, which I understood
>>> to be the official package and binary naming so they wanted me to clarify
>>> that.
>>>
>>> The two package types don't seem to be mutually exclusive and I'm happy to
>>> do the work to figure out what is proper if there is interest in a pull
>>> request.
>>>
>>> Any thoughts? I feel like this would be worthwhile because of how much
>>> easier it makes working with OpenImageIO on windows and can't foresee any
>>> negative impact on other platforms.
>>>
>>> Cheers,
>>>
>>> Alan
>>
>>> _______________________________________________
>>> Oiio-dev mailing list
>>> [email protected] <mailto:[email protected]>
>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>>
>> --
>> Larry Gritz
>> [email protected] <mailto:[email protected]>
>>
>>
>>
>>
>> _______________________________________________
>> Oiio-dev mailing list
>> [email protected] <mailto:[email protected]>
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>>
>>
>> _______________________________________________
>> Oiio-dev mailing list
>> [email protected] <mailto:[email protected]>
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected] <mailto:[email protected]>
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
> <CMakeLists.txt.patch>_______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
