For anybody reading this who has been looking for a way to get involved in OIIO... this is an ideal case of a "good first issue" -- doesn't require deep code knowledge, will be a < 10 line fix, and the gist of what needs to be done is already laid out here.
If you want to give it a try, please say so here so that there aren't 10 people trying to do the same fix (I wish) or that I don't do it instead, thinking that nobody else will. -- lg > On May 7, 2023, at 10:26 PM, Larry Gritz <l...@larrygritz.com> wrote: > > Ah, interesting. So that sounds like we should downgrade the version of fmt > that is automatically downloaded when none is found locally -- currently 9.1, > but we should use something older to ensure it can compile with all the gcc > versions we claim to support. > > And maybe we also should double check and warn if the fmt it found is not > going to work with the gcc being used? > > Do you think those two changes would adequately address the problem? > > > >> On May 7, 2023, at 9:54 PM, Fabrice Macagno <fabrice.maca...@al.com.au >> <mailto:fabrice.maca...@al.com.au>> wrote: >> >> Hi there, this is more an FYI: fmt-9.1.0 >> <https://github.com/OpenImageIO/oiio/blob/32a361ab3ed6479725f0b22d591a436728cfe640/src/cmake/externalpackages.cmake#L322> >> cannot be built with gcc lesser than 7.3. The issue was fixed >> <https://github.com/fmtlib/fmt/pull/3066> not long after 9.1.0 release. >> >> Knowing this could hopefully save some time for those, like us, who haven't >> moved yet to gcc-9.3 (we're on it though 😉) >> >> There are several ways to configure OIIO's build to work around the problem. >> Also, clang builds are fine. >> -- >> Fabrice Macagno (He/Him) >> Technical Lead >> >> T: +61 2 9383 4800 (main) >> D: +61 2 8063 2951 (direct) >> E: fabrice.maca...@al.com.au <mailto:fabrice.maca...@al.com.au> >> >> Building 54, 38 Driver Ave >> Moore Park, NSW 2021 >> AUSTRALIA >> >> <https://www.linkedin.com/company/animal-logic> >> <https://www.facebook.com/Animal-Logic-129284263808191/> >> <https://twitter.com/AnimalLogic> >> <https://www.instagram.com/animallogicstudios/> >> >> <http://www.animallogic.com/> >> >> Animal Logic acknowledges the Traditional Custodians, the Bidjigal people >> and Gadigal people of the Eora Nation, on whose land we meet, work and >> travel through. We pay our respects to Elders past, present and emerging, >> and extend our respect to Aboriginal and Torres Strait Islander people from >> all Nations of this land. >> >> CONFIDENTIALITY AND PRIVILEGE NOTICE >> This email is intended only to be read or used by the addressee. It is >> confidential and may contain privileged information. If you are not the >> intended recipient, any use, distribution, disclosure or copying of this >> email is strictly prohibited. Confidentiality and legal privilege attached >> to this communication are not waived or lost by reason of the mistaken >> delivery to you. If you have received this email in error, please delete it >> and notify us immediately by telephone or email. >> _______________________________________________ >> Oiio-dev mailing list >> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org> >> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > -- > Larry Gritz > l...@larrygritz.com <mailto:l...@larrygritz.com> > > > > > > _______________________________________________ > Oiio-dev mailing list > Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> -- Larry Gritz l...@larrygritz.com
_______________________________________________ Oiio-dev mailing list Oiio-dev@lists.openimageio.org http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org