I agree that stricter settings are nicer, but I would argue that we should only generate warnings for areas that we are really going to fix.
The mantra we have taken on our team is a "An Empty 'Problems' Window" -- which we mean no errors and no warnings. So, if when we decide to turn a warning on, we are also deciding at that point to fix the problems then to clear all the warnings. It does us no good to see a problems window with ~1500 warnings if you don't plan to fix them, because then you just begin to ignore it all together. On the same breath -- I am also checking in to that same file formatter settings as well, that should match what the standard is stated on the website. This will allow the use of Ctrl-Shift-F inside of Eclipse to give standard results for everyone. Thoughts? -Andrew > -----Original Message----- > From: Jakob Braeuchi [mailto:[EMAIL PROTECTED] > Sent: Wednesday, August 17, 2005 3:47 PM > To: OJB Developers List > Subject: Re: Code Cleanup > > hi andrew, > > i found it ! no need to import/export. > but i prefer stricter settings: > > > #Wed Aug 17 21:42:59 CEST 2005 > eclipse.preferences.version=1 > org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=disabled > org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.2 > org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve > org.eclipse.jdt.core.compiler.compliance=1.4 > org.eclipse.jdt.core.compiler.debug.lineNumber=generate > org.eclipse.jdt.core.compiler.debug.localVariable=generate > org.eclipse.jdt.core.compiler.debug.sourceFile=generate > org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning > org.eclipse.jdt.core.compiler.problem.assertIdentifier=warning > org.eclipse.jdt.core.compiler.problem.autoboxing=ignore > org.eclipse.jdt.core.compiler.problem.deprecation=ignore > org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedC > ode=disabled > org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridin > gDeprecatedMethod=disabled > org.eclipse.jdt.core.compiler.problem.discouragedReference=warning > org.eclipse.jdt.core.compiler.problem.emptyStatement=warning > org.eclipse.jdt.core.compiler.problem.enumIdentifier=warning > org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore > org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning > org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletin > gNormally=warning > org.eclipse.jdt.core.compiler.problem.forbiddenReference=error > org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning > org.eclipse.jdt.core.compiler.problem.incompatibleNonInherited > InterfaceMethod=warning > org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore > org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=warning > org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore > org.eclipse.jdt.core.compiler.problem.methodWithConstructorNam > e=warning > org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotat > ion=ignore > org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore > org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning > org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning > org.eclipse.jdt.core.compiler.problem.noImplicitStringConversi > on=warning > org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLit > eral=ignore > org.eclipse.jdt.core.compiler.problem.overridingPackageDefault > Method=warning > org.eclipse.jdt.core.compiler.problem.possibleAccidentalBoolea > nAssignment=warning > org.eclipse.jdt.core.compiler.problem.specialParameterHidingFi > eld=disabled > org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning > org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled > org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore > org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning > org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning > org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning > org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning > org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning > org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning > org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore > org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExce > ption=ignore > org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExce > ptionWhenOverriding=enabled > org.eclipse.jdt.core.compiler.problem.unusedImport=warning > org.eclipse.jdt.core.compiler.problem.unusedLocal=warning > org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore > org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImple > mentingAbstract=disabled > org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverr > idingConcrete=disabled > org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning > org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning > org.eclipse.jdt.core.compiler.source=1.3 > > jakob > > Jakob Braeuchi schrieb: > > hi andrew, > > > > how can i import/export those settings in eclipse ? > > > > jakob > > > > Clute, Andrew schrieb: > > > >> In order to make our Eclipse project cleaner, I have gone > through and > >> tried to clean up as much as possible from our code. This most > >> included removing unnecessary casts and imports. > >> > >> One of the nice things about Eclipse 3.1 is there is now > the option > >> to do project-based compiler warnings -- and that file can > be added to CVS. > >> That means everyone can have the exact same settings for > those types > >> of things. > >> > >> As a first pass at it, I took the default values, but then turned > >> down to ignore two settings: Use of deprecated code (which > we have a > >> bunch > >> of) and unused variables. > >> > >> Just an FYI, and would love any feedback. > >> > >> NOTE: I have only done this for the 1.0 line right now. > >> > >> -Andrew > >> > >> > >> > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] For > > additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] For > additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
