Vadim Gritsenko wrote:
I'd like to prepare set of patches to implement support of the stored procedures returning a result set. In order to do this platform independently, I'd like to get opinions on whether following changes to the Platform interface are acceptable or not.

  * Add a method to check if statement is a CallableStatement or not:
        isCallableStatement(PreparedStatement stmt);
...
  * Add a method to register stored procedure result as a ResultSet.
        registerOutResultSet(CallableStatement stmt, int position);
...
  * Add a method to retrieve result set from the CallableStatement.
        getResultSet(CallableStatement stmt);

Looks good to me. The platform interface is there for this purpose; to be able to move RBDMS differences below the other OJB API layers.


As usual a set of "qualified defaults" should go into the default impl (as you suggest).

To make sure proper implementations get added for each platform, it's a good idea to create a few testcases that will fail until platform support is complete. The Torque SQL-generation in 1.0 branch seems unable to do things like generate stored procedures for the tests, but this might be possible with the OJB 1.1 testing framework?

Regards,
 Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to