Antonio Gallardo wrote:
I found small concerns in this commmit, please read comments between lines.
mkalen 2005/04/10 11:28:21
Log:
Upgrade ANTLR to v2.7.5. Re-generate lexers/parsers from *.g. Tweak oql
grammar to optimize some imports. Bump copyright years, update Eclipse
classpaths and docs.
1.23.2.1 +40 -14 db-ojb/src/java/org/apache/ojb/odmg/oql/oql-ojb.g
+/* mkalen: Notice from the original mdbs oql.g (do not touch Antlr
version): */
<snip/>
/*
** oql.g
**
-** Built with Antlr 2.7.1
+** Built with Antlr 2.5
Please fix. ;-)
That is a notice from the original oql.g from mdbs, see my notice above.
We are not generating oql.g and must keep original copyright and notices
verbatim.
- * The original grammar has been modified to fit into the ObJectBridge
(OJB)
+ * The original grammar has been modified to fit into the OJB
^^^
|||
Should be "Apache OJB"?
Don't know, but when pointed out "the OJB" sounds a bit funny.
Next person to touch the grammar can choose a better wording if they like.
- * This OQL grammar has been derived from a OQL sample grammar from the
ODMG
- * WebSite. The original grammar is copyright protected by MicroData
Base
- * Systems: Copyright (c) 1999 Micro Data Base Systems, Inc. All rights
- * reserved.
+/* Copyright 2003-2005 The Apache Software Foundation
Is correct to change here the Copyright?
It is just moved around in the grammar, not changed.
Please see the whole file in CVS to get a better overview.
I am also not a laywer, so if both licenses (mdbs and ASF) needs to be in
both places please let us know.
Regards,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
