arminw      2005/09/06 15:30:29

  Modified:    src/test/org/apache/ojb OJB-logging.properties
                        OJB.properties repository_database.xml
  Log:
  refactoring of statement handling:

  - StatementManager implementation does now more strict control all statement 
handling (creation, closing, binding) and support a simple stmt caching if jdbc 
driver, ConnectionFactory or DataSource doesn't support this feature 
(configurable via custom-attributes in connection-factory element or via setter 
at runtime).

  - StatementManager provide new convenience methods to get prepared statements 
with binded values (in one method call)
  
  Revision  Changes    Path
  1.6       +1 -3      db-ojb/src/test/org/apache/ojb/OJB-logging.properties
  
  Index: OJB-logging.properties
  ===================================================================
  RCS file: /home/cvs/db-ojb/src/test/org/apache/ojb/OJB-logging.properties,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- OJB-logging.properties    27 Aug 2005 12:46:14 -0000      1.5
  +++ OJB-logging.properties    6 Sep 2005 22:30:29 -0000       1.6
  @@ -65,8 +65,6 @@
   org.apache.ojb.broker.accesslayer.JdbcAccessImpl.LogLevel=WARN
   # Logger for RsIterator, useful for debugging problems with Object 
materialization
   org.apache.ojb.broker.accesslayer.RsIterator.LogLevel=WARN
  -# Logger for StatementsForClass, useful for debugging JDBC Connection 
related problems
  -org.apache.ojb.broker.accesslayer.StatementsForClassImpl.LogLevel=WARN
   # Logger for SqlGenerator, useful for debugging generation of SQL
   org.apache.ojb.broker.accesslayer.sql.SqlGeneratorDefaultImpl.LogLevel=WARN
   # Logger for RepositoryPersistor
  
  
  
  1.83      +4 -11     db-ojb/src/test/org/apache/ojb/OJB.properties
  
  Index: OJB.properties
  ===================================================================
  RCS file: /home/cvs/db-ojb/src/test/org/apache/ojb/OJB.properties,v
  retrieving revision 1.82
  retrieving revision 1.83
  diff -u -r1.82 -r1.83
  --- OJB.properties    27 Aug 2005 12:46:14 -0000      1.82
  +++ OJB.properties    6 Sep 2005 22:30:29 -0000       1.83
  @@ -174,19 +174,12 @@
   #
   
CollectionProxyClass=org.apache.ojb.broker.core.proxy.CollectionProxyDefaultImpl
   #
  +#
   
#----------------------------------------------------------------------------------------
   # StatementManager
   
#----------------------------------------------------------------------------------------
   # The StatementManagerClass entry defines the StatementManager 
implemementation to be used
  -StatementManagerClass=org.apache.ojb.broker.accesslayer.StatementManager
  -#
  -#
  
-#----------------------------------------------------------------------------------------
  -# StatementsForClass
  
-#----------------------------------------------------------------------------------------
  -# The StatementsForClassClass entry defines the StatementsForClass 
implemementation to be used
  -# to implement cached statements.
  
-StatementsForClassClass=org.apache.ojb.broker.accesslayer.StatementsForClassImpl
  +StatementManagerClass=org.apache.ojb.broker.accesslayer.StatementManagerImpl
   #
   #
   
#----------------------------------------------------------------------------------------
  @@ -339,7 +332,7 @@
   # Note: If OJB's ordering is enabled the order of objects may change
   # at commit of the transaction.
   # This setting can be changed at runtime using OJB's ODMG extensions.
  -NoteUserOrder=true
  +NoteUserOrder=false
   #
   #
   # Set the specific odmg-LockManager used in ODMG implementation
  
  
  
  1.28      +14 -7     db-ojb/src/test/org/apache/ojb/repository_database.xml
  
  Index: repository_database.xml
  ===================================================================
  RCS file: /home/cvs/db-ojb/src/test/org/apache/ojb/repository_database.xml,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- repository_database.xml   27 Aug 2005 12:46:14 -0000      1.27
  +++ repository_database.xml   6 Sep 2005 22:30:29 -0000       1.28
  @@ -52,11 +52,14 @@
           >
               <!-- add attributes supported by the ConnectionFactory class 
here -->
               <!-- Set fetchSize to 0 to use driver's default. -->
  -            <attribute attribute-name="fetchSize" attribute-value="0"/>
  -
  -            <!-- Attributes with name prefix "jdbc." are passed directly to 
the JDBC driver. -->
  -            <!-- Example setting (used by Oracle driver when Statement 
batching is enabled) -->
  -            <attribute attribute-name="jdbc.defaultBatchValue" 
attribute-value="5"/>
  +            <attribute attribute-name="ojb.fetchSize" attribute-value="0"/>
  +            <!-- Enable/disable OJB's internal statement caching. This only
  +            make sense when the used jdbc-driver/ConnectionFactory doesn't
  +            support statement caching -->
  +            <attribute attribute-name="ojb.cacheStatements" 
attribute-value="false"/>
  +            <!-- If OJB's statement caching is enabled, this property set 
the max number
  +             of cached statements per connection -->
  +            <attribute attribute-name="ojb.maxCacheStatements" 
attribute-value="20"/>
   
               <!-- Attributes with name prefix "pool." supported by 
ConnectionFactoryPooledImpl
               and ConnectionFactoryDBCPImpl -->
  @@ -79,7 +82,7 @@
               with DBCP ObjectPool-based PreparepdStatement caching (ie 
setting true
               here has no effect for Oracle9i platform). -->
               <attribute attribute-name="dbcp.poolPreparedStatements" 
attribute-value="false"/>
  -            <attribute attribute-name="dbcp.maxOpenPreparedStatements" 
attribute-value="10"/>
  +            <attribute attribute-name="dbcp.maxOpenPreparedStatements" 
attribute-value="20"/>
               <!-- Attribute determining if the Commons DBCP connection 
wrapper will allow
                    access to the underlying concrete Connection instance from 
the JDBC-driver
                    (normally this is not allowed, like in J2EE-containers 
using wrappers). -->
  @@ -88,6 +91,10 @@
               <attribute attribute-name="dbcp.removeAbandoned" 
attribute-value="false"/>
               <attribute attribute-name="dbcp.removeAbandonedTimeout" 
attribute-value="300"/>
   
  +            <!-- Attributes with name prefix "jdbc." are passed directly to 
the JDBC driver. -->
  +            <!-- Example setting (used by Oracle driver when Statement 
batching is enabled) -->
  +            <attribute attribute-name="jdbc.defaultBatchValue" 
attribute-value="5"/>
  +
           </connection-factory>
   
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to