Hi, > thanks for the patch! > Sorry for the late reply!
Thanks. I had to explain about getUniqueLong. In my environment (MySQL and ojb-cvs), patched SequenceManagerNativeImpl needs to change getUniqueLong to return 0 to work correctory. But I didn't try ojb's junit-test. That was like a quick hack. > I got problems running the patched version of > SequenceManagerNativeImpl against the > NativeIdentifierTest junit-test. "Old" version pass > the test without problems, integrating your patch > one test case fails. > > Does the actual version of NativeIdentifierTest pass with your > modified SequenceManagerNativeImpl (test only works with > hsql and mysql, I only run against hsql)? Ok, I will check out cvs and test and research the cause. > > I want SequenceManagerNativeImpl to support init property to define > > this value. That can be 0 or -1. And it must be depend on DB type. > > we can use a custom attribute to make this configurable. > But when I set 0 as return value most test cases fail > (NativeIdentifierTest) Then, It seems that MySQL needs 0, and others need -1. proper value seems to depend on DB. But NativeIdentifierTest dosen't allow to use 0. I don't comprehend PersistenceBroker completely and haven't read NativeIdentifier yet. I will try junit-test for NativeIdentifier and read source file. > > Yesterday, I found another bug in SequenceManagerMySQLImpl. > > MySQL returns long array SELECT LAST_INSERT_ID() query, > > so getting new id takes long time when table has many records. > > Just adding ' LIMIT 1 ' at the end fixes this performance problem. > > sorry I'm not a "DB-guy", so have patience with me ;-) > do you mean > "SELECT LAST_INSERT_ID() "+tablename+" LIMIT 1" > ?? Yes, it is. That will work with no problem and improve performance. Sorry, I don't have exact answer now. Please wait. # Did you remove "access=readonly" ? # Patched version seems to needs that to work correctly. regards, -- shivaken antshell: Ant command line front end http://www.antshell.org --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
