https://bugs.kde.org/show_bug.cgi?id=181290





--- Comment #96 from Kevin Kofler <kevin kofler chello at>  2011-06-06 00:58:41 
---
This is what I came up with:
https://git.reviewboard.kde.org/r/101513/

I fixed the duplicate code, moving the orientation detection to the
Okular::Document class in core/document.cpp. I also adapted the other 3
generators using FilePrinter::printFile (in addition to the Poppler/PDF one).

The FilePrinter::printFiles function (which takes multiple files at once) still
doesn't do orientation properly, but I don't see this being used anywhere in
Okular.

I haven't done any testing yet though. Falk, can you please test this patch? 
(On my side, I'm going to build it in Fedora's Koji build system shortly to
verify that it is compilable and hopefully get more people to test it.)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Reply via email to