> On Aug. 8, 2011, 7:10 a.m., Pino Toscano wrote: > > There's a GSoC currently working on text selection, and IIRC it was going > > to work also on that (branch "selection_and_highlighting"). > > Brian Korbein wrote: > Looks like it is fixed in that branch, so I will mark this as discarded.
Thanks a lot for caring about Okular, bad luck that the patch you fixed was already fixed though - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102250/#review5489 ----------------------------------------------------------- On Aug. 8, 2011, 4:48 a.m., Brian Korbein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102250/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2011, 4:48 a.m.) > > > Review request for Okular. > > > Summary > ------- > > Append a space after each word of a selection area in djvu files. > ddjvu_document_get_pagetext which is used to extract the text from djvu files > strips any spaces from the text, storing each word in an s-exp that looks > like this: > (<int>,<int>,<int>,int>,"string"). > It is probably possible to reconstruct the exact spacing from the 4 coords, > but just appending a space fixes the issue enough for my needs. > Fixes bug# 230787 > > > This addresses bug 230787. > http://bugs.kde.org/show_bug.cgi?id=230787 > > > Diffs > ----- > > generators/djvu/kdjvu.cpp 302a69b > > Diff: http://git.reviewboard.kde.org/r/102250/diff > > > Testing > ------- > > I tested using the djvu testfile included in the bug, as well as several > pdfs, all of which worked as expected. There does seem to be an issue with > the bug's testfile where selecting the blank space in the left margin finds > an invisible word, but that seems unrelated. > > > Thanks, > > Brian > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
