----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102788/#review7439 -----------------------------------------------------------
ui/pageview.cpp <http://git.reviewboard.kde.org/r/102788/#comment6462> I am confused about you doing tally+=thing and then asserting that tally is equal to 0. Is this to verify the algorithm is working? - Albert Astals Cid On Oct. 14, 2011, 3:25 a.m., Jiri Baum wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102788/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2011, 3:25 a.m.) > > > Review request for Okular. > > > Description > ------- > > Automatic row and column dividers for the table selection tool, as per the > bug description. > > The table selection tool as per bug #279859 requires the user to manually > indicate all the column and row dividers. However, in many situations it's > trivial for the tool to detect the rows and columns automatically. It can't > get it right every time, but it can get it right often and some of the > remaining times it can at least get close. As long as the > automatically-detected column and row dividers are easy to clear, they will > save more time than they will cost. > > Dividers are placed in any place where they will not intersect any letter and > the gap is not zero-width. A special case is made for selections spanning > multiple pages to avoid placing dividers that cannot be seen (instead of a > divider in the gap between pages, two dividers are placed, one each side). > > > This addresses bug 283440. > http://bugs.kde.org/show_bug.cgi?id=283440 > > > Diffs > ----- > > core/page.h 67bcf97 > core/page.cpp eaab64e > core/textpage.h 2bdc09d > core/textpage.cpp 7096e90 > ui/pageview.h cd88b99 > ui/pageview.cpp 25da571 > > Diff: http://git.reviewboard.kde.org/r/102788/diff/diff > > > Testing > ------- > > Works for me... > > > Thanks, > > Jiri Baum > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
