> On Dec. 19, 2011, 10:55 p.m., Albert Astals Cid wrote: > > What about: > > > > "There are two issues left with it, however: > > > > - 'ThumbnailListPrivate::getNewPageOffset' still has to be updated to work > > with Rotation180 > > - There is currently no code for switching pages in either Rotation90 or > > Rotation270" > > > > Is that done? > > > > Tomorrow (today?) tuesday 20 it is RC1, my question is, do you think this > > is "better" than what we have and that it'll introduce no regressions? I'm > > a little worried about it being a big-ish change and since it's been broken > > for a long time i was thinking that maybe we can leave it for 4.9? What do > > you think?
Michel? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103060/#review9108 ----------------------------------------------------------- On Dec. 19, 2011, 5:06 p.m., Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103060/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2011, 5:06 p.m.) > > > Review request for Okular. > > > Description > ------- > > Implement the handling of page rotations for source references. > > > Diffs > ----- > > core/document.h df65d52 > core/document.cpp 74757f1 > core/page.h 46fba72 > core/page.cpp bb3dbbd > core/utils.h 8d5d5fc > core/utils.cpp 5dd8448 > generators/dvi/generator_dvi.cpp 16d124b > generators/poppler/generator_pdf.cpp 7095e47 > part.cpp 7db0c0b > ui/pagepainter.cpp ca55e81 > ui/pageview.h 4a8e287 > ui/pageview.cpp 78a007a > ui/side_reviews.cpp 40a7adf > ui/thumbnaillist.cpp ebaef9c > > Diff: http://git.reviewboard.kde.org/r/103060/diff/diff > > > Testing > ------- > > > Thanks, > > Michel Ludwig > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
