> On Aug. 15, 2012, 2:32 p.m., Albert Astals Cid wrote: > > part.cpp, line 1300 > > <http://git.reviewboard.kde.org/r/105965/diff/5/?file=77775#file77775line1300> > > > > This is wrong, what happens with the openUrlFromDocument calls?
I have moved this to openUrlFromDocument. > On Aug. 15, 2012, 2:32 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 130 > > <http://git.reviewboard.kde.org/r/105965/diff/5/?file=77777#file77777line130> > > > > This is not what i meant. And this probably won't work since what will > > happen when you open a file from http:// ? What i meant was using the > > Document::isOpened information fixed another bug in part.cpp, where if the document fails to load, the url is reset to KUrl(). - Jaydeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105965/#review17447 ----------------------------------------------------------- On Aug. 15, 2012, 10:05 p.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105965/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 10:05 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch is a fix for the bug-166645, as listed here > (https://bugs.kde.org/show_bug.cgi?id=166645) > > Opens a new instance of Okular for every other file that is opened. > > > Diffs > ----- > > part.h d9a5cc4 > part.cpp 7c1ca71 > part.rc 33d3829 > shell/shell.cpp 8b42a27 > shell/shell.rc 93fbc41 > > Diff: http://git.reviewboard.kde.org/r/105965/diff/ > > > Testing > ------- > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
