> On Nov. 12, 2012, 12:03 a.m., Albert Astals Cid wrote:
> > Michel, I want to apoligize, I've been ultra busy with lots of other stuff 
> > and could not make the review in time for this to be included in the 4.10 
> > release. It is totally my fault, I will try to get it in 4.11. I hope this 
> > is not blocking the kile release that has live preview, right?

Hi Albert,

don't worry, I've also been extremely busy in the last weeks and I might not 
even have had the time to do any more changes to the patch if they had been 
required.

This patch doesn't block the live preview feature but I noticed that I might 
need a few more functions in the ViewerInterface; hence, I might have to come 
up with a ViewerInterface2... ;)


- Michel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103060/#review21850
-----------------------------------------------------------


On Sept. 26, 2012, 8:16 p.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103060/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 8:16 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Implement the handling of page rotations for source references.
> 
> 
> Diffs
> -----
> 
>   core/document.h d47acec 
>   core/document.cpp 7f006e6 
>   core/page.h a8f2761 
>   core/page.cpp d746382 
>   core/utils.h 8d5d5fc 
>   core/utils.cpp 5dd8448 
>   generators/dvi/generator_dvi.cpp 5cd327f 
>   generators/poppler/generator_pdf.cpp fcc8dc4 
>   part.cpp 2ef39d8 
>   ui/pagepainter.cpp 537e5c5 
>   ui/pageview.h 9f56620 
>   ui/pageview.cpp 496abdc 
>   ui/side_reviews.cpp a35f9ed 
>   ui/thumbnaillist.cpp 60288cb 
> 
> Diff: http://git.reviewboard.kde.org/r/103060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Reply via email to