----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review24314 -----------------------------------------------------------
core/annotations.cpp <http://git.reviewboard.kde.org/r/107442/#comment18665> You don't need the if, delete 0 is a valid delete that does nothing core/document.h <http://git.reviewboard.kde.org/r/107442/#comment18664> const & for the QStrings core/document.h <http://git.reviewboard.kde.org/r/107442/#comment18662> const core/document.h <http://git.reviewboard.kde.org/r/107442/#comment18663> const ui/pageview.cpp <http://git.reviewboard.kde.org/r/107442/#comment18660> If you change the .rc action names to edit_undo and edit_redo you won't need these addAction calls (see how it works for KStandardAction::Copy for example) - Albert Astals Cid On Dec. 31, 2012, 3:12 a.m., Jon Mease wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107442/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2012, 3:12 a.m.) > > > Review request for Okular. > > > Description > ------- > > This patch is a first cut at adding undo/redo support to Okular. This patch > is not yet complete, however it is far enough along that I would like to > begin incorporating feedback from the community. > > Functionality: > The following actions can be undone and redone: creation and removal of > annotations, editing arbitrary annotation properties, relocating annotations > with Ctrl+drag, and editing the text contents of an annotation. > > This patch does not yet include support for undoing and redoing editing > actions on forms. I plan to implement this form undo functionality before > the functionality of this patch is included in Okular. > > Known Issue: > When editing an annotation's properties in a .dvi file the annotation is > altered and the action can be undone as expected. However, when editing an > annotation's properties in a .pdf file the image of the original annotation > is not removed from the document when the altered annotation appears. I > would appreciate any possible leads on this issue. > > > > This addresses bug 177501. > http://bugs.kde.org/show_bug.cgi?id=177501 > > > Diffs > ----- > > core/annotations.h 72abdff > core/annotations.cpp 49ab5bd > core/document.h 1d825e1 > core/document.cpp 00e290d > core/document_p.h 4a20561 > core/page.cpp 4df58e0 > generators/poppler/annots.cpp b7fb9f7 > part.rc 39c1571 > ui/annotationpropertiesdialog.cpp 4b02258 > ui/annotwindow.h f7df9f6 > ui/annotwindow.cpp c1bafb9 > ui/pageview.cpp 811a169 > > Diff: http://git.reviewboard.kde.org/r/107442/diff/ > > > Testing > ------- > > I have tested the undoing and redoing of the specified annotation actions > using .dvi and .pdf documents. The only known issue is the one described > above when using .pdf files. > > > Thanks, > > Jon Mease > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
