> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote: > > generators/txt/CMakeLists.txt, line 6 > > <http://git.reviewboard.kde.org/r/109009/diff/1/?file=114309#file114309line6> > > > > This probably should go away?
Fixed in patch r2. > On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote: > > generators/txt/active-documentviewer_txt.desktop, line 4 > > <http://git.reviewboard.kde.org/r/109009/diff/1/?file=114310#file114310line4> > > > > Clean all the translations, that's for our translators and translation > > script to maintain. Fixed in patch r2. > On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote: > > generators/txt/converter.h, line 10 > > <http://git.reviewboard.kde.org/r/109009/diff/1/?file=114311#file114311line10> > > > > bad define name Fixed in patch r2. > On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote: > > generators/txt/converter.h, line 27 > > <http://git.reviewboard.kde.org/r/109009/diff/1/?file=114311#file114311line27> > > > > This red that reviewboard shows maybe means you're mixing tabs & spaces > > or something? Fixed in patch r2. > On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote: > > generators/txt/converter.cpp, line 16 > > <http://git.reviewboard.kde.org/r/109009/diff/1/?file=114312#file114312line16> > > > > Do you need all these includes? Fixed in patch r2. > On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote: > > generators/txt/document.cpp, line 25 > > <http://git.reviewboard.kde.org/r/109009/diff/1/?file=114314#file114314line25> > > > > This seems like it should be a debug not a warning Fixed in patch r2. > On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote: > > generators/txt/document.cpp, line 55 > > <http://git.reviewboard.kde.org/r/109009/diff/1/?file=114314#file114314line55> > > > > warning -> debug > > empty space at the end of line Fixed in patch r2. - Azat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109009/#review27676 ----------------------------------------------------------- On Feb. 18, 2013, 11:07 p.m., Azat Khuzhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109009/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 11:07 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Description > ------- > > Simple txt backend for okular. > > Development history: > https://github.com/azat/okular/compare/master...add-txt-support > > From mailing list: > http://comments.gmane.org/gmane.comp.kde.devel.okular/13279 > > > Diffs > ----- > > generators/txt/document.cpp PRE-CREATION > generators/txt/generator_txt.h PRE-CREATION > generators/txt/generator_txt.cpp PRE-CREATION > generators/txt/libokularGenerator_txt.desktop PRE-CREATION > generators/txt/okularApplication_txt.desktop PRE-CREATION > generators/txt/okularTxt.desktop PRE-CREATION > generators/CMakeLists.txt 5a101bf > generators/txt/CMakeLists.txt PRE-CREATION > generators/txt/active-documentviewer_txt.desktop PRE-CREATION > generators/txt/converter.h PRE-CREATION > generators/txt/converter.cpp PRE-CREATION > generators/txt/document.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109009/diff/ > > > Testing > ------- > > Tested manually. > > > Thanks, > > Azat Khuzhin > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
