----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109119/#review28231 -----------------------------------------------------------
Code looks, ok, but now the big question, is this really an improvement? I guess the only improvement would be speed-wise and not encoding-detection-wise. Have you opened really big files and noticed it is faster? Otherwise maybe there is no really need to change the existing code if it works as well? - Albert Astals Cid On Feb. 25, 2013, 8:15 p.m., Azat Khuzhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109119/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 8:15 p.m.) > > > Review request for Okular. > > > Description > ------- > > Don't to extra job, when encoding is detected just return encoding. > > > Diffs > ----- > > generators/txt/document.h 08babea > generators/txt/document.cpp badb647 > > Diff: http://git.reviewboard.kde.org/r/109119/diff/ > > > Testing > ------- > > > Thanks, > > Azat Khuzhin > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
