----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29667 -----------------------------------------------------------
It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially? - Albert Astals Cid On March 21, 2013, 1:26 a.m., Peter Grasch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109632/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 1:26 a.m.) > > > Review request for Okular. > > > Description > ------- > > Prerequisites: Please read till the end! > > This introduces a new annotation tool: "Eraser". > > The eraser primarily erases other annotations that it comes into contact with > (shapes, lines, highlights, etc.). > > However, ink annotations are treated more like a real eraser: Existing paths > are split and unaffected parts are preserved. > This is what it looks like: http://bedahr.org/eraser.ogv > > > Example tool configuration for your tools.xml (not included in patch): > > <tool id="15" name="Eraser" pixmap="tool-eraser-okular"> > <tooltip>Eraser</tooltip> > <engine type="Eraser" /> > <shortcut>7</shortcut> > </tool> > > The eraser builds on the work for the outline selection proposed in review > request #109627. Please apply that patch before this one. > > > Diffs > ----- > > ui/pageviewannotator.cpp 7bd7496 > > Diff: http://git.reviewboard.kde.org/r/109632/diff/ > > > Testing > ------- > > While it worked fine for the few PDFs I threw at it on this relatively > powerful machine, it was pointed out to me in #okular, that calls to > modifyPageAnnotation are very expensive as poppler has to re-draw the pdf > (with the annotations) for every change. > I hope we can resume the discussion about possible improvements here. > > > Thanks, > > Peter Grasch > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
