----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/#review30342 -----------------------------------------------------------
That "forbidden" cursor is weird since for example if i am drawing a yellow line i can actually click outside of the page and it will do stuff. Maybe it should only be "forbidden" if we are not "in the middle" of using a tool? - Albert Astals Cid On March 23, 2013, 9:01 p.m., Peter Grasch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109633/ > ----------------------------------------------------------- > > (Updated March 23, 2013, 9:01 p.m.) > > > Review request for Okular. > > > Description > ------- > > The open hand cursor is imho very inconvenient for inconvenient for most > types of annotations. Especially ink annotations are much more useful with > that added bit of control (the open hand cursor covers the virtual "pen tip"). > > The patch itself feels a bit contrived. Please let me know if there is a > better way to do this given Okulars architecture. > > > Diffs > ----- > > ui/pageview.h 5e839f2 > ui/pageview.cpp e8d481d > ui/pageviewannotator.h 850d887 > ui/pageviewannotator.cpp 4615d1c > > Diff: http://git.reviewboard.kde.org/r/109633/diff/ > > > Testing > ------- > > Tested successfully: Tool selection, deselection, continuous mode. > > > Thanks, > > Peter Grasch > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
