> On July 6, 2013, 6:11 p.m., Albert Astals Cid wrote: > > Sincerely, i understand you may find this useful, but I am not sure this > > makes much sense, it's just feature creep, anyway, even if it does make > > sense, it's not in the correct place, why is all this exporting > > functionality in pageview.cpp? If at all this should be integrated with the > > File->Export functionality and not be coded in pageview.cpp but in the > > proper appropiate backend, I don't think calling an external tool is a good > > idea, but it is true it's the only "easy" way to provide the functionality
s/it's just feature creep/I think it's a bit of feature creep - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/#review35667 ----------------------------------------------------------- On July 5, 2013, 10:10 p.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111410/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 10:10 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch implements the feature request of bug 321350: if a PDF file is > viewed, the selection tool offers the new extraction method "vector" which > allows to save to a file (PDF, SVG, EPS, PostScript). The crop operation is > performed by calling "pdftocairo" with matching arguments. The resulting file > contains the original PDF file's content without rendering it to a pixmap. > > I am not sure if calling an external program is an acceptable solution for > this problem. However, it is tested if the program is available before > showing the new option. Alternatively, the code of pdftocairo (as part of > poppler) would had to be copied and integrated into Okular increasing the > solution's complexity. I am not aware of a similar solution available using > poppler-qt4 only. Maybe using a QPrinter printing to PDF would have been an > alternative, but again this seemed to be too complex. > > > Diffs > ----- > > ui/pageview.cpp 16b00ab > > Diff: http://git.reviewboard.kde.org/r/111410/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
