> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote: > > shell/main.cpp, line 53 > > <http://git.reviewboard.kde.org/r/110914/diff/3/?file=183075#file183075line53> > > > > Just commenting here, but please try to review all your code. It's good > > if you can try to make all the variables that never change (like services) > > const, this way a second person that reads over the code, does not have to > > struggle finding if that may change or not. Yes i know we don't apply that > > over all the okular code, but we're trying to add good practices :-)
Do you want everything as const as possible? For example, there are places I can do "const Type* const" but I think "Type*" or "const Type*" is cleaner. How about function parameters (int vs const int)? - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110914/#review38086 ----------------------------------------------------------- On Aug. 17, 2013, 3:06 p.m., Jonathan Doman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110914/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2013, 3:06 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch adds support for a tabbed interface (multiple documents in one > window). The core work just adds a tab bar that switches between multiple > embedded okularparts, but there are many other considerations: > - Tab context menu allows for duplicating or detaching (detached tabs start > in new okular process) > - `okular file.pdf` will open file in existing window if possible, unless > --new flag is used. It also selects the most recently raised/activated window > to use. This mirrors behavior I expect from browsers and other tabbed > interfaces. > - Warns when closing window with multiple tabs > - No warning is given when opening an already open file. This is the > behavior I strongly prefer (and observe in other programs), but will change > if there is consensus otherwise. > > When selecting different tools in one part, the tool selection propagates to > all parts, but the GUI does not reflect that. This bug is present in other > programs (e.g. multiple okularparts in Konqueror), so I made no attempt to > diagnose or fix. > > One menu item was added for the multiple tab warning option. When testing > this, I noticed that items in the Settings menu seem to move around when > switching tabs, and I cannot diagnose or fix this. It seems to be related to > XMLGUI bug #64754. > > My development branch is also hosted at > https://github.com/jrmrjnck/okular-tabbed > > > This addresses bug 155515. > http://bugs.kde.org/show_bug.cgi?id=155515 > > > Diffs > ----- > > part.h 4b3aafdb637080ae81eb0e45742f53a34738984d > part.cpp 71c3d0f5d908969ffcf18aba327297ccd2e1c8e1 > shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4 > shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 > shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 > shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 > > Diff: http://git.reviewboard.kde.org/r/110914/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Doman > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
