-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110914/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 6:58 a.m.)
Review request for Okular.
Changes
-------
Okay, I simplified the tab related features. No DBus changes, no cmdline
interface changes (multiple arguments opens multiple windows), no close
warnings.
Bugs: 155515
http://bugs.kde.org/show_bug.cgi?id=155515
Repository: okular
Description
-------
This patch adds support for a tabbed interface (multiple documents in one
window). The core work just adds a tab bar that switches between multiple
embedded okularparts, but there are many other considerations:
- Tab context menu allows for duplicating or detaching (detached tabs start in
new okular process)
- `okular file.pdf` will open file in existing window if possible, unless
--new flag is used. It also selects the most recently raised/activated window
to use. This mirrors behavior I expect from browsers and other tabbed
interfaces.
- Warns when closing window with multiple tabs
- No warning is given when opening an already open file. This is the behavior
I strongly prefer (and observe in other programs), but will change if there is
consensus otherwise.
When selecting different tools in one part, the tool selection propagates to
all parts, but the GUI does not reflect that. This bug is present in other
programs (e.g. multiple okularparts in Konqueror), so I made no attempt to
diagnose or fix.
One menu item was added for the multiple tab warning option. When testing this,
I noticed that items in the Settings menu seem to move around when switching
tabs, and I cannot diagnose or fix this. It seems to be related to XMLGUI bug
#64754.
My development branch is also hosted at
https://github.com/jrmrjnck/okular-tabbed
Diffs (updated)
-----
shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6
shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983
Diff: http://git.reviewboard.kde.org/r/110914/diff/
Testing
-------
Thanks,
Jonathan Doman
_______________________________________________
Okular-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/okular-devel
