> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 4485 > > <https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485> > > > > Can you explain why the need for a timer? > > Yichao Zhou wrote: > This is because, in scroll mode, user just moves their mouse a little bit > and then does nothing. The screen will automatically scroll until user exits > scroll mode (by another mouse click). > > In order to let the screen scroll duratively, you will need a timer. > > Albert Astals Cid wrote: > And this is why the whole bug makes no sense. Okular already has a way to > scroll that is using the left mouse button. And now you want to make the fact > that middle mouse button also scrolls but in a different way. This makes no > sense at all. I'm not going to continue reviewing this unless someone > explains me why Okular should have two different ways of scrolling. > > Yichao Zhou wrote: > I do not quite understand this. How can I use the left mouse to do > scroll? If you mean in "Broswer" mode and use the mouse to drag the page, > then I can argue that > > 1. Using the middle mouse is more suitable when you want to scroll a > large distance. The "drag" method is not very convenient when you want to > scroll more than a screen: you need to move the mouse to the bottom of the > screen, drag it to the top and then repeat this until you scroll to your > target. _You need move your mouse a lot_. But for middle mouse, it is > relatively simpler: You do a middle click. Then you move you mouse down a > little bit (the scroll speed is determined by this displacement). Then the > page starts to scroll. You wait until the page scrolls to the target > position and then you do another click to stop the scroll. _You do not need > to move your mouse a lot and you can achieve a higher scroll speed than using > left mouse's method_. > > 2. For people migrated from adobe reader (or Windows), they maybe more > happier using middle wheel to scroll according to their habit. (Although > this is short, I think this is the main reason people request this feature on > the KDE Bugtracking System). > > 3. Using middle mouse to scroll works in all mode including the > "Broswer" mode.
1. Really? Have you even tried Okular? Because you do *not* need to drag your mouse to the top... 2. Do you know of any other app that uses that totally non standard way of scrolling? 3. So? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/#review48417 ----------------------------------------------------------- On Feb. 4, 2014, 4:39 a.m., Yichao Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115335/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 4:39 a.m.) > > > Review request for Okular. > > > Bugs: 219121 > http://bugs.kde.org/show_bug.cgi?id=219121 > > > Repository: okular > > > Description > ------- > > According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I > implemented that feature with an option in accessibility pages. > > > This patch also fixes some problems in the original patch, and provides more > features, including > * In scroll mode, you can press ctrl key to enter zoom mode > * Now you can use middle key to scroll in all mouse mode (broswer, zoom, > selection, etc.) > * In scroll mode, now okular can load new page correctly > > > Diffs > ----- > > conf/dlgaccessibilitybase.ui 9e76a75 > conf/okular.kcfg deabd07 > ui/pageview.h 9c15af6 > ui/pageview.cpp 65967bf > > Diff: https://git.reviewboard.kde.org/r/115335/diff/ > > > Testing > ------- > > > Thanks, > > Yichao Zhou > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
