----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/#review49310 -----------------------------------------------------------
ui/presentationwidget.cpp <https://git.reviewboard.kde.org/r/115072/#comment34803> I don't think you should change the global setting, the button feels more like a "local/temporary" thing than the user wanting to change the main setting. What do you think? - Albert Astals Cid On Jan. 29, 2014, 8:29 a.m., Saheb Preet Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115072/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 8:29 a.m.) > > > Review request for Okular. > > > Bugs: 328125 > http://bugs.kde.org/show_bug.cgi?id=328125 > > > Repository: okular > > > Description > ------- > > Okular don't have any play pause button in the presentation mode. > > Implemented a playpause action in the action collection in part.cpp. > > Used this action in presentationwidget.cpp to add it to the toolbar. Finally > connected it to a slot defined in presentationwidget.h > > In this slot when the signal is triggered on the next page timer is initiated > and its single shot behaviour is turned off. The icon is changed to the pause > button icon > > When the signal is triggered off the next page timer is stopped and its > single shot behaviour is reverted back to true. The icon is changed to the > play button. > > > Diffs > ----- > > part.cpp 88e2c41 > ui/presentationwidget.h c63e119 > ui/presentationwidget.cpp 1b63e2f > > Diff: https://git.reviewboard.kde.org/r/115072/diff/ > > > Testing > ------- > > tested on local machine, working as desired. > > > Thanks, > > Saheb Preet Singh > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
