----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113973/#review50774 -----------------------------------------------------------
This review has been submitted with commit f22d9d28973713011114266e3c5d3235484a0d14 by Albert Astals Cid on behalf of Michal Humpula to branch master. - Commit Hook On Feb. 23, 2014, 8:59 p.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113973/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2014, 8:59 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > I realy missed the magnifying glass feature from the old kdvi, which comes > very handy if you are doing typesetting. So I finaly told myself to hack it > in and here comes the patch for it. > > The 01-hack.patch is allowing the document to render big pixmaps for non > tiled views. The rest is quite straightforward. > > The magnifier can scroll the view "apropriately", doesn't fall of the edges > and hovers correctly from one page to another. > > So the remaining question is, what is the status of this: > core/document_p.h:213 "// FIXME This is a hack, we need to support multiple > tiled observers, but for the moment we only support one" > Is someone working on it? > > > Diffs > ----- > > CMakeLists.txt 63d2922 > conf/okular.kcfg f954c9a > part.rc 0b9cee5 > ui/magnifierview.h PRE-CREATION > ui/magnifierview.cpp PRE-CREATION > ui/pageview.h 9c15af6 > ui/pageview.cpp 7c7f785 > > Diff: https://git.reviewboard.kde.org/r/113973/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
