> On March 4, 2014, 12:09 a.m., Albert Astals Cid wrote: > > This was already implemented, sorry we forgot to close the bug. > > Swarn Kumar wrote: > Yeah, you should have. It took me an hour. > > Albert Astals Cid wrote: > No, you should have tried if it worked before you did anything. First > lesson learned, don't assume a bug exists just because someone filed it, > check first.
Am new to KDE hacking and I don't know but why would someone file a bug, if it isn't there? - Swarn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116578/#review51845 ----------------------------------------------------------- On March 4, 2014, 12:09 a.m., Swarn Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116578/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 12:09 a.m.) > > > Review request for Okular. > > > Bugs: 328576 and Bug > http://bugs.kde.org/show_bug.cgi?id=328576 > http://bugs.kde.org/show_bug.cgi?id=Bug > > > Repository: okular > > > Description > ------- > > Added keyPressEvent(QKeyEvent* ) for creating shortcut for 'search previous' > action (SHIFT+ENTER). > > > Diffs > ----- > > ui/searchlineedit.cpp f4969da > ui/searchlineedit.h 63ff496 > > Diff: https://git.reviewboard.kde.org/r/116578/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Swarn Kumar > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
