----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115391/#review56337 -----------------------------------------------------------
Burkhard? - Albert Astals Cid On Jan. 29, 2014, 9:23 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115391/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 9:23 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > A) So far it is only possible to select an icon via GUI in an editable > Combobox with: > 1) Select one of the icon from stamp.svg in the combobox > (translated stamp names, but untranslated text in the stamps like "Approved" > etc) > 2) enter an icon name into the combobox (very hidden feature for me) > If an icon with this name is found in "kde4-config - -path icon" it will be > used then > To use a custom icon, is has to be placed in `kde4-config - > -localprefix`/share/icons/ > This works only for icons with lower case names, I do not know why and if > this is an > intended behavior > > B) To allow the user to select a custon icon via the GUI I made these changes: > 1) Set property of combobox in PixmapPreviewSelector to non editable, this > only used > to select on of the icons provided by Okular from stamp.svg > 2) Add a checkbox and a kiconbutton > Activating the checkbox disables the PixmapPreviewSelector and enables the > kiconbutton > which opens the common "Select Icon" dialog. In this dialog you can select > either a > System icon from several groups (Applications, Actions etc) or check "Other > icons" > and open the default file dialog with Filter "Icon Files (*.png *.xpm *.svg > *.svgz)" > to select your custom icon from anywhere in the filesystem. > > C) Basically this patch works as expected but there are some issues I could > not solve or > where I need some input/advice: > 1) Loads only icons with lower case names, why this restriction + how to > remove it? > 2) The Filter preset "Icon Files (*.png *.xpm *.svg *.svgz)" could have > better defaults > maybe png, jpeg, others?. svg + svgz do not really seem to make sense here? > 3) Disabling the PixmapPreviewSelector and enabling the kiconbutton (and vice > versa) > via the checkbox works in the "Edit annotation tool" dialog opened from the > configuration dialog, but not in the "Stamp Properties" dialog opened with > "Properties" > from the context menu of a stamp annotation, but why? > > > Diffs > ----- > > ui/annotationwidgets.h 6e7a218 > ui/annotationwidgets.cpp 450e50b > > Diff: https://git.reviewboard.kde.org/r/115391/diff/ > > > Testing > ------- > > Works for me in locale x-test wit the limitations in C) > > > Thanks, > > Burkhard Lück > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
