----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review56807 -----------------------------------------------------------
ui/pageview.cpp <https://git.reviewboard.kde.org/r/115283/#comment39653> can you name them kPage to make it more clear they are some kind of special value (i.e. a constant)? ui/pageview.cpp <https://git.reviewboard.kde.org/r/115283/#comment39652> These occurrences of 6 and 12 should be replaced by your new static too. ui/pageview.cpp <https://git.reviewboard.kde.org/r/115283/#comment39650> We don't need this, do we? ui/pageview.cpp <https://git.reviewboard.kde.org/r/115283/#comment39651> Maybe add a break inside the if so we don't continue looping? - Albert Astals Cid On March 18, 2014, 5:59 a.m., Saheb Preet Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115283/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 5:59 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 326844 > http://bugs.kde.org/show_bug.cgi?id=326844 > > > Repository: okular > > > Description > ------- > > okular do not have a feature to resize the current window to the current page > size. > > The bug is solved upto some extent, the window is resizing as desired. > > resize method of qwidget class is used to resize the window. > > The window is resizing as required but sometimes it doesn't resizes . It has > to be moved by mouse and then again click on the button in the menu to resize > the window again. Once it is moved by mouse, it works fine. Now, when the > zoom level is changed, the problem starts again. > > I think the problem occurs due to something happening in the other portion of > the code. > > I searched about it on the internet and nobody was able to answer the > solution to people with same problem. There are some alternative solutions to > the problem:- > > ==> Use set geometry instead of resize which works fine. but would have to be > taken care of the size of the screen and the original position of the window. > Also, repainting the portion outside the window when the window is resized to > a smaller window. > > ==> Use a timer which will signal a slot which in turn will resize the > window, but that might require qsignalmapper to map the width and height to > the slot. ( I didn't tried this solution ). > > The best solution i could find on the internet is this > http://qt-project.org/forums/viewthread/25648 > > Also, there is one more issue, the fit window to page button in the view menu > is enabled by default. It should not be enabled when no document is open. > Where should the code for enabling this button should be implemented. > > > Diffs > ----- > > part.h 010e9de > part.cpp 4ce7e28 > part.rc 60f86e5 > shell/shell.h 3b9aae0 > shell/shell.cpp 01a9f1b > ui/pageview.h 577b908 > ui/pageview.cpp dd41994 > > Diff: https://git.reviewboard.kde.org/r/115283/diff/ > > > Testing > ------- > > > tested when > ==> window is maximized and restored. > ==> thumbnails, table of content are opened and closed. > ==> various toolbars are shown and hidden. > ==> for all the zoom levels shown in the toolbar and custom zoom level ( > example 123.23% ). > > > Thanks, > > Saheb Preet Singh > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
