----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119595/#review63990 -----------------------------------------------------------
Ship it! Haven't had time to build and test, but the code looks good to me. - Jonathan Doman On Aug. 3, 2014, 3 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119595/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2014, 3 p.m.) > > > Review request for Okular and Jonathan Doman. > > > Bugs: 334100 > http://bugs.kde.org/show_bug.cgi?id=334100 > > > Repository: okular > > > Description > ------- > > Use a QString to serialize the command line options other than urls to open > so it can be easily passed around to every place that opens a new shell or > tab or overrides the content in a unique instance. > > Maybe there's something the autotest does not test but it'd be a cornercase, > I'd like to have this for 4.14 > > > Diffs > ----- > > shell/main.cpp 61e2113 > shell/okular_main.h PRE-CREATION > shell/okular_main.cpp PRE-CREATION > shell/shell.h e540054 > shell/shell.cpp 55f4f12 > shell/shellutils.h 6c0c228 > shell/shellutils.cpp 26c6825 > tests/CMakeLists.txt 3b3fbdd > tests/mainshelltest.cpp PRE-CREATION > conf/settings.kcfgc 9064d15 > core/document.cpp 921a7e8 > core/document_p.h aabd192 > shell/CMakeLists.txt 521a216 > > Diff: https://git.reviewboard.kde.org/r/119595/diff/ > > > Testing > ------- > > I have an autotest! > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
