> On Aug. 21, 2014, 9:13 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3675 > > <https://git.reviewboard.kde.org/r/119878/diff/2/?file=306798#file306798line3675> > > > > Removing this ifs makes the feature regress, the actions (Fit Width, > > Fit Height) are not marked anymore on the menu. > > Markus Trippelsdorf wrote: > No. They are still marked in PageView::updateZoomText(). > > Albert Astals Cid wrote: > No they are not, what is updated in PageView::updateZoomText is the combo > box text, not the menu actions.
Ah, you're right. I never use the menu, so I didn't notice. - Markus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119878/#review64998 ----------------------------------------------------------- On Aug. 21, 2014, 9:10 p.m., Markus Trippelsdorf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119878/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 9:10 p.m.) > > > Review request for Okular. > > > Bugs: 335819 > http://bugs.kde.org/show_bug.cgi?id=335819 > > > Repository: okular > > > Description > ------- > > This fixes a couple of zoom related bugs by moving zoomFactorFitWidth and > zoomFactorFitPage > handling from PageView::updateZoom to PageView::updateZoomText. > It also avoids duplicate zoom values. > > > Diffs > ----- > > ui/pageview.cpp 48d5d8df191c > > Diff: https://git.reviewboard.kde.org/r/119878/diff/ > > > Testing > ------- > > > Thanks, > > Markus Trippelsdorf > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
