> On Jan. 29, 2015, 8:15 nachm., Albert Astals Cid wrote: > > Somebody that cares about the frameworks branch, please review, or just > > commit it, it's not like the frameworks branch is something we're releasing > > soon.
Is this a ship it? - Johannes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122155/#review74996 ----------------------------------------------------------- On Jan. 19, 2015, 7:56 nachm., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122155/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 7:56 nachm.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > If both qt4 and qt5 versions of qca are present the build of the > frameworks branch tries to find Qt4 pulled in by qca and thus fails. > > > This is similiar to what has been done to konversation and muon > http://quickgit.kde.org/?p=konversation.git&a=commit&h=3aa918b5e3ac0f90a76d55c2bab12fafcbb1279b > http://quickgit.kde.org/?p=muon.git&a=commit&h=fd76f5ad43228689127cb4f12c0fbc6d65f4b373 > > Note: I don't have commit access so I'd need someone to push this for me. > > > Diffs > ----- > > generators/ooo/CMakeLists.txt 61054bd8f01af0ac5bee42c58f46f54b2f560f92 > > Diff: https://git.reviewboard.kde.org/r/122155/diff/ > > > Testing > ------- > > Successfully built with -DCMAKE_DISABLE_FIND_PACKAGE_Qca-qt5:BOOL=FALSE AND > TRUE and okular linked to the right version of qca in the former case. > > > Thanks, > > Heiko Becker > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel