----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123909/#review85408 -----------------------------------------------------------
The diff doesn't apply cleanly against master, can you please update it? - Albert Astals Cid On ago. 31, 2015, 8:21 p.m., Nikola Nikolic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123909/ > ----------------------------------------------------------- > > (Updated ago. 31, 2015, 8:21 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 336381 > http://bugs.kde.org/show_bug.cgi?id=336381 > > > Repository: okular > > > Description > ------- > > Added import/export functionality with similar workflow as in File->Export > As... > Bookmarks ( only viewports and titles ) are saved in binary file with > .okularbm extension. > Import/Export is available only for currently opened document. > I haven't used any document identification, because document name and size > can change. > > > Diffs > ----- > > part.h 9eebdb2 > part.cpp d461ebe > part.rc 60f86e5 > > Diff: https://git.reviewboard.kde.org/r/123909/diff/ > > > Testing > ------- > > Tested both functionalities, it seems they work. > This is only an idea how import/export may be implemened, any suggestions for > improvement are welcome. > P.S. Any ideas on how to identify a document properly, so I can implement > Import All/Export All functionalities? > > > Thanks, > > Nikola Nikolic > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel