----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125741/#review87623 -----------------------------------------------------------
Ship it! Ship It! - Albert Astals Cid On oct. 25, 2015, 2:05 p.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125741/ > ----------------------------------------------------------- > > (Updated oct. 25, 2015, 2:05 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > okular/part.cpp includes interfaces/viewerinterface.h and its > OKULARCORE_EXPORT macro gets expanded into __declspec(dllimport). This makes > VS linker to drop ViewerInterface::~ViewerInterface() definition and to look > for it in KF5OkularCore.dll. But this include is never used anywhere in > okularcore, hence missing symbol. > > Including interfaces/viewerinterface.h in any of okularcore sources fixes the > problem. > > > Diffs > ----- > > interfaces/viewerinterface.h 4f27921 > > Diff: https://git.reviewboard.kde.org/r/125741/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
