> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote: > > Ship It!
Great. - Fahad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review97739 ----------------------------------------------------------- On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125397/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 5:07 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 325650 > http://bugs.kde.org/show_bug.cgi?id=325650 > > > Repository: okular > > > Description > ------- > > This is my first patch to okular, so I am newbie here. This patch adds RTL > reading mode to okular in following view modes: > - facing pages. > - facing ( center first page). > - Overview. > > As well as adds “Right to left reading direction “ option to okular's > settings. > > > Diffs > ----- > > conf/dlggeneral.cpp 9945522 > conf/dlggeneralbase.ui 03d5d5d > conf/okular.kcfg d90fe23 > ui/pageview.cpp 26373bb > > Diff: https://git.reviewboard.kde.org/r/125397/diff/ > > > Testing > ------- > > I have tested in pdf & ODF files and it works fine. > > > Thanks, > > Fahad Al-Saidi > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel