----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129099/#review99787 -----------------------------------------------------------
I honestly don't see the benefit You changed a delete by a reset, is there any benefit at all other than making the code harder to read? - Albert Astals Cid On Oct. 4, 2016, 8:33 p.m., Oliver Sander wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129099/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 8:33 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > Because it has ownership semantics. > > The code would be even shorter with std::make_unique, but that is C++14. Is > that allowed in Okular? > > > Diffs > ----- > > ui/presentationwidget.h 69574d2 > ui/presentationwidget.cpp c16d616 > > Diff: https://git.reviewboard.kde.org/r/129099/diff/ > > > Testing > ------- > > > Thanks, > > Oliver Sander > >
