----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129791/#review101881 -----------------------------------------------------------
Fix it, then Ship it! core/document.cpp (line 2203) <https://git.reviewboard.kde.org/r/129791/#comment68155> We probably want the same check here, right? - Albert Astals Cid On Jan. 8, 2017, 11:21 a.m., Antonio Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129791/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2017, 11:21 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 374650 > http://bugs.kde.org/show_bug.cgi?id=374650 > > > Repository: okular > > > Description > ------- > > If a generator can open two mime types that match the same file, okular will > show a selection dialog containing two copies of the same generator when > opening that file. This patch avoids having duplicates in the backend list. > > > Diffs > ----- > > core/document.cpp 19526627 > > Diff: https://git.reviewboard.kde.org/r/129791/diff/ > > > Testing > ------- > > Tried opening a PDF, okular opens it directly. Before this patch, if the > "Show backend selection dialog" option was enabled, it would show a backend > selection dialog with two copies od the poppler generator. > > > Thanks, > > Antonio Rojas > >
