----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 -----------------------------------------------------------
This works fine for me without your patch, so it's either that you use too old versions and the new ones are fixed or that i use too old versions and the new one has regressed. Which KF5/Qt5 versions are you using. - Albert Astals Cid On Feb. 1, 2017, 12:56 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 12:56 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` is not seekable and because of that > `QImageLoader` can't detect image format. Proposed solution: if that device > is not seekable or `QIODevice::size()` returns 0, copy its content into a > temporary file and load image from it. > > > Diffs > ----- > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > ------- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >
