> On Mar. 11, 2017, 4:51 p.m., Albert Astals Cid wrote: > > ui/findbar.cpp, line 50 > > <https://git.reviewboard.kde.org/r/129956/diff/2/?file=491729#file491729line50> > > > > Why this line?
Because when we call *m_automaticSearchAct->setChecked( Okular::Settings::searchAutomatic() )* and *Okular::Settings::searchAutomatic()* is false, the signal *&QAction::toggled* won't be emitted since the checked property is false by default. If *Okular::Settings::searchAutomatic()* is true, *&QAction::toggled* will be emitted and on line 183, *m_search->lineEdit()->setAutomaticSearch* will be called with *true* as argument. > On Mar. 11, 2017, 4:51 p.m., Albert Astals Cid wrote: > > ui/findbar.cpp, line 72 > > <https://git.reviewboard.kde.org/r/129956/diff/2/?file=491729#file491729line72> > > > > I think "Find as you type" is much better than "Automatic search", what > > do you think? Yes, I think so, too. Do I have to change variables names, functions names etc? (I think yes) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129956/#review102788 ----------------------------------------------------------- On Feb. 20, 2017, 8:50 a.m., Marco Scarpetta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129956/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2017, 8:50 a.m.) > > > Review request for Okular. > > > Bugs: 326522 > http://bugs.kde.org/show_bug.cgi?id=326522 > > > Repository: okular > > > Description > ------- > > Implement an option to disable the automatic search while typing in okular > findbar. When the "automatic search" option is disabled the user must press > the return key to start searching. > > > Diffs > ----- > > conf/okular.kcfg e06dd91b > ui/findbar.h 2c34d0de > ui/findbar.cpp 09201e78 > ui/searchlineedit.h b8230e65 > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129956/diff/ > > > Testing > ------- > > I ran okular and tested that both searching modes work. > > > Thanks, > > Marco Scarpetta > >
