This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 10, 2017, 3:32 p.m.)


This change has been marked as submitted.

Review request for Okular.


Submitted with commit 0c4c2ddbbc5e509c69b72c99bf6e83a356669eba by Oliver Sander 
to branch master.

Repository: okular


When the users chooses to print with rasterization and annotations, it is easy 
to print directly to a QPrinter, rather than converting to PostScript and then 
using CUPS tools.  The code for it was already there, but it was hidden behind 
an #ifdef Q_OS_WIN. This patch enables it for all plattforms.  If nothing else, 
it will make an interesting debugging tool, because it allows to bypass the 
postscript & cups toolchain from the GUI. This may allow to track down some of 
the numerous my-printer-settings-are-getting-ignored bugs.
Incidentally, this patch does fix at least one bug for me: Without it, my 
printer will happily ignore the 'print in grayscale' button.  With the patch, 
that button is suddenly honoured.

This patch is a part of https://git.reviewboard.kde.org/r/130055/ .  I post it 
here separately because I am not sure anymore whether the other stuff in that 
larger patch is a good idea.


  generators/poppler/generator_pdf.cpp 42ccb3a26 

Diff: https://git.reviewboard.kde.org/r/130218/diff/


Printed a few test sheets, to a printer and a file.


Oliver Sander

Reply via email to