progwolff added a comment.

  
  
  In https://phabricator.kde.org/D7382#138593, @aacid wrote:
  
  > It doesn't build on Ubuntu 17.04
  
  
  In this revision unknown flags are defined to 0. This should allow us to 
build with older versions of discount.
  I also set the minimum version to 2.
  
  I don't have access to a Ubuntu system right now. Could you try it again?

INLINE COMMENTS

> aacid wrote in converter.cpp:57
> 980x1307 is an interesting size, any specific reaosn you choose that one?

980 is the width github uses to show README.md documents. This means many 
documents will be optimized for this width.
980x1307 then matches the aspect ratio of 600x800, wich is used by other 
generators.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7382

To: progwolff, #okular
Cc: michaelweghorn, aacid

Reply via email to