rkflx created this revision. Restricted Application added a project: Okular.
REVISION SUMMARY This should prevent crashes when reloading some synctex-enabled pdf files created with newer versions of TeXLive. We also gain bugfixes, features and improved accuracy from the last 6 years of synctex development. Procedure followed: - svn co svn://tug.org/texlive/trunk/Build/source/texk/web2c/synctexdir - Check out revision 45150 - Update files present in core/synctex/* - Adapt Okular code to changes - Review and drop or update/apply old patches using quilt - Create missing patches for local synctex changes - New patch: Omit warning message when opening non-synctex pdf - Two new patches to fix more compiler warnings TODO for later: - Move sync file detection code to Okular to never call into synctex C code for non-synctex files - Evaluate feasibility of upstreaming all patches for TeXLive 2018 and using synctex as a library BUG: 383915 FIXED-IN: 17.12.0 TEST PLAN - No crash in synctex on reloading empty.pdf from bugreport anymore. - Shift-clicking on a word in a simple pdf opens Kate with the corresponding tex line. - Works with tex files from both TeXLive 2015 and 2017. - PartTest::testForwardPDF still passes. REPOSITORY R223 Okular BRANCH synctex-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D7594 AFFECTED FILES autotests/parttest.cpp core/document.cpp core/document_p.h core/synctex/patches/00-disable-SYNCTEX_INLINE.diff core/synctex/patches/01-fix-win32-define.diff core/synctex/patches/04-gcc-specify-printf-format.diff core/synctex/patches/05-fix-error-formats.diff core/synctex/patches/06-mingw-_synctex_error.diff core/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff core/synctex/patches/08-fix_cpp_comments.diff core/synctex/patches/09-fix_path_comparison.diff core/synctex/patches/10-fix-typo.diff core/synctex/patches/11-fix-unused-parameters-warnings.diff core/synctex/patches/12-omit-no-file-warning.diff core/synctex/patches/13-fix-Wundef-warnings.diff core/synctex/patches/14-fix-misc-compiler-warnings.diff core/synctex/patches/series core/synctex/synctex_parser.c core/synctex/synctex_parser.h core/synctex/synctex_parser_advanced.h core/synctex/synctex_parser_local.h core/synctex/synctex_parser_readme.md core/synctex/synctex_parser_readme.txt core/synctex/synctex_parser_utils.c core/synctex/synctex_parser_utils.h core/synctex/synctex_parser_version.txt To: rkflx, #okular, sander Cc: aacid
