sander added a comment.
From merely looking at the patches, I like this one better than Albert's. In Albert's patch, the fact that you have to set m_areWeReloading at every exit of the method slotDoFileDirty does feel like breakage waiting to happen. On the other hand, Albert's objection "Using a mutex when threads are not involved is wrong in my book" is not without reason either. Casual readers of the code will see the mutex and expect there to be threading. I therefore suggest to expand the comment in part.cpp:1773 to clearly state why the mutex is needed, and why it does not have anything to do with threading. Is that a reasonable compromise? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7595 To: rkflx, #okular Cc: sander, aacid
