ngraham created this revision. ngraham added a project: Okular. REVISION SUMMARY Changed the colors used from the active theme so that there is never a white-on-light-blue situation that makes the text unreadable. Here are the changes when using the Breeze color scheme: - When an inactive tab is hovered over, the text is now dark (was light before) - When a selected tab loses focus, the text is now dark (was light before) Tested to make sure dark themes do not experience a regression. BUG: 382139
TEST PLAN Tested on KDE Neon (dev unstable). Verified that with the default Breeze color scheme, tab text is more readable when hovered over and then active but not in focus. See before and after: F3909143: After.png <https://phabricator.kde.org/F3909143> F3909142: Before.png <https://phabricator.kde.org/F3909142> Also tested these changes with all standard color schemes shipped with Neon to make sure that there were no visual regressions. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7793 AFFECTED FILES ui/sidebar.cpp To: ngraham, aacid, #okular, #kde_applications, broulik, sander Cc: aacid